fable-compiler / fable-react

Fable bindings and helpers for React and React Native
MIT License
273 stars 67 forks source link

Fix notation for SVG attributes SSR #193

Closed mvsmal closed 4 years ago

mvsmal commented 4 years ago

This PR fixes notation in SSR for some of the predefined SVG attributes. The changes are made according to this reference: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute

MangelMaxime commented 4 years ago

Thank you it has been released in version 6.2.0

mvsmal commented 4 years ago

hi @MangelMaxime ! Thanks a lot for the quick merge an release! Would it be possible to release this fix also in version 5.x? The problem is that we cannot even work it around since SVGAttr.Custom is rendered with slugKey and we are not ready to update to v.6 yet.

MangelMaxime commented 4 years ago

Sure, version 5.4.0 has been released with the fix in it