search

fable-compiler / fable-react

Fable bindings and helpers for React and React Native
MIT License
273 stars 67 forks source link

Add Custom DU to DOMAttr #221

Closed selketjah closed 2 years ago

selketjah commented 2 years ago

HTMLAttr has Custom of string * obj and SVGAttr also has this, but it is missing from DOMAttr:

https://github.com/fable-compiler/fable-react/blob/e1233110fbd37f1e38b2d27b1934ca60c7622ee4/src/Fable.React.Props.fs#L183-L184

https://github.com/fable-compiler/fable-react/blob/e1233110fbd37f1e38b2d27b1934ca60c7622ee4/src/Fable.React.Props.fs#L378

Would it be possible to also add this to DOMAttr for completeness?

alfonsogarciacaro commented 2 years ago

Hi @selketjah! You're right, DOMAttr.Custom should be added for consistency. I will release a new version. Thanks for pointing that out!