search

fable-compiler / repl-legacy

http://fable.io/repl
MIT License
14 stars 10 forks source link

Generate assembly metadata in build script #31

Open alfonsogarciacaro opened 6 years ago

alfonsogarciacaro commented 6 years ago

The metadata for Fable.Core.dll is outdated, we should generate it automatically with every build (and Fable.Import.Browser.dll).

ncave commented 6 years ago

The "Generate.Metadata" target does that, but it's referencing Fable.Core 1.3.*

<PackageReference Include="Fable.Core" Version="1.3.*" />
<PackageReference Include="Fable.Import.Browser" Version="*" />

Let me know if you want that changed to, say, 1. or just for both.

alfonsogarciacaro commented 6 years ago

Using 1.* could be a good idea, though now that I started 2.0 development, maybe there's no Fable 1.4 after all ;)

ncave commented 6 years ago

@alfonsogarciacaro I updated the references, so just use the netstandard2.0 binares, performance should be more or less the same.

alfonsogarciacaro commented 6 years ago

@ncave I've run the Generated.Metadata target (with a fresh clone of your FCS fork). netstandard assemblies are working fine but for some reason I cannot use Fable.Core.jsOptions in the REPL. If it's using the latest Fable.Core that helper should be available. Any hint?

ncave commented 6 years ago

@alfonsogarciacaro You can open and examine the dll with dnSpy to make sure it's there.

ncave commented 6 years ago

@alfonsogarciacaro Looks like it has Fable.Core.JsInterop.jsOptions, but not Fable.Core.jsOptions

alfonsogarciacaro commented 6 years ago

Slap me in the face please.

Slap me

Actually, Fable.Core.JsInterop was open but the sample was using jsOption (missing s at the end). It works now, sorry for the hustle!

I'm like a mogwai, I shouldn't code after midnight...