search

fable-compiler / repl

Fable online REPL
http://fable.io/repl
MIT License
61 stars 34 forks source link

Add infrastructure to be able translate REPL This is based on suggestions from #185 #186

Closed kant2002 closed 6 months ago

kant2002 commented 10 months ago

This is based on suggestions from #185

I have translation for Ukrainian and Russian, but want to gather feedback on the approach. I think that's it, and no additional strings needed, or that amount would be very small.

I have to add dependency on Fable.Browser.Navigator since tha allow account for user preferences.

MangelMaxime commented 6 months ago

Hello @kant2002.

Sorry for the long wait.

I have been conflicted about this PR because this is always intimidating to add translation to a project. And also, I had some plan to rewrite the REPL which didn't happen yet as I probably want to rework some stuff upstream first.

With all that said, I made a few changes to move the translations to their own file and also allows the user change the language setting from the application itself.

This is because sometimes even if your browser is in a certain local you can prefer to see the application in english for example.

kant2002 commented 6 months ago

No big deal, If I was really need it, I either work with fork, or bombard you with notifications. I think I still have small things which I can improve unrelated to translation.

Most interesting for me is phone support for REPL which is not ideal. So you maybe hear from me soon )))

kant2002 commented 6 months ago

I'm really glad that I may improve submit important for me changes upstream and worry less about live with them in personal fork.