fablevi / HideItems

This GNOME extension made every item hidden exept the Settings and this button 🎉
https://extensions.gnome.org/extension/6771/hide-items/
GNU General Public License v3.0
11 stars 3 forks source link

Small inconsistencies in appearance #3

Closed Naezr closed 4 months ago

Naezr commented 5 months ago

The button is too long relative to the icon inside it. I suggest to make the button shorter. Also, the arrow icon is too thin and does not match the standard GNOME style. Maybe you could use a system-provided icon instead of your own to match different themes.

изображение изображение

Overall though, it's a very cool extension, especially with the introduction of customization of which icons to hide. This is very handy because it allows you to hide not only tray icons, as in Tray Icons Reloaded, but also buttons of other extensions.

Also, as an idea for development I can suggest this: You could make it so that when you click on a button, hidden icons would appear not in the panel, but in a popup window, like Windows Tray. It would be very cool, taking into account that buttons of any extensions could be placed there.

hedgieinsocks commented 4 months ago

Yeah, pls consider using these:

<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" height="16px" viewBox="0 0 16 16" width="16px"><path d="m 9.292969 13.707031 l -5 -5 c -0.390625 -0.390625 -0.390625 -1.023437 0 -1.414062 l 5 -5 c 0.390625 -0.390625 1.023437 -0.390625 1.414062 0 s 0.390625 1.023437 0 1.414062 l -4.292969 4.292969 l 4.292969 4.292969 c 0.390625 0.390625 0.390625 1.023437 0 1.414062 s -1.023437 0.390625 -1.414062 0 z m 0 0" fill="white" fill-rule="evenodd"/></svg>
<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" height="16px" viewBox="0 0 16 16" width="16px"><path d="m 6.707031 13.707031 l 5 -5 c 0.390625 -0.390625 0.390625 -1.023437 0 -1.414062 l -5 -5 c -0.390625 -0.390625 -1.023437 -0.390625 -1.414062 0 s -0.390625 1.023437 0 1.414062 l 4.292969 4.292969 l -4.292969 4.292969 c -0.390625 0.390625 -0.390625 1.023437 0 1.414062 s 1.023437 0.390625 1.414062 0 z m 0 0" fill="white" fill-rule="evenodd"/></svg>

Also, it would be nice to set the max width of the button pill to 51 which seems to be the standard (like language switch).

By the way, I have to use my https://github.com/hedgieinsocks/gnome-extension-lineup to normalize the indicators. Perhaps the dev would be interested in implementing something like that.

fablevi commented 4 months ago

Okey, i will test new icon styles to mix in GNOME's style, but the icon width is the default, i'm not change anything about it.

My icons like this: Screenshot from 2024-03-31 14-04-00

Maybe if i have some time i will write some settings to set the icon width as you want, but rn i don't have any time. Thanks for the report :)