search

fabmob / CMS

Compte Mobilité Standardisé
Apache License 2.0
9 stars 2 forks source link

phone_number_field different between PersonalInformation and DGFIP scopes #10

Open giffarda opened 1 year ago

giffarda commented 1 year ago

https://github.com/fabmob/CMS/blob/110ac7e2aa9985e571f2423cf35ee24cb08d241d/conceptual_model/schemas/personal-information.schema.json#L146-L150

https://github.com/fabmob/CMS/blob/110ac7e2aa9985e571f2423cf35ee24cb08d241d/conceptual_model/schemas/fr-dgfip-information.schema.json#L276-L279

Hi,

For phone number field type, a boolean "mobile" was added. It is indicated in the DGFIP schema.json but not in PersonalInformation schema.json. Can you confirm we want this boolean in all scopes which need a phone number ?

Thanks in advance

jthiard commented 1 year ago

There seems to be a mismatch between the json schemas and the markdown documentation for that matter.

To move this forward I suggest that we add this mobile property in all places where a phone number is expected, but that we make this property optional (it is required in the DGFIP scope at the moment).

Does this will fit your use case ?

giffarda commented 1 year ago

Yes, it is good for us. In my opinion, the important thing is that the phone number type is the same in all over the specification, as much as possible. The property mobile can be required or optional, but optional seems to be a right choice.