search

fabn / activeadmin-globalize

Provides translation UI for ActiveAdmin and Globalize gems
https://github.com/fabn/activeadmin-globalize
MIT License
30 stars 54 forks source link

Style the flags select for empty/inactive values in translated_row #18

Closed jtomaszewski closed 7 years ago

jtomaszewski commented 7 years ago

Fixes https://github.com/fabn/activeadmin-globalize/issues/2 .

fabn commented 7 years ago

@jtomaszewski this commit seems good, did you tried it in a local environment? Are you using master versions of Globalize and Active Admin?

The only issue I see is that this PR is missing some specs, I'd like to have them before merging.

Are you able to write some specs for this feature? I understand that you might not be able to run current specs on your machine even if last build was green, so if you try and fail please report and I'll try to help you.

fabn commented 7 years ago

I see that your PR in #17 is build with green status on Travis (just some warnings), so this failure it's not an issue with newer versions of dependencies but with this PR itself.

You should try to fix them and to implement a test for this feature before I can accept this change.

jtomaszewski commented 7 years ago

Yeah, give me a day or two and I'll make the specs. Both commits seems to be working for me on development and staging.

jtomaszewski commented 7 years ago

Specs fixed and pushed with --force to this PR branch.

fabn commented 7 years ago

Good, merging this.

Thanks for your contribution.