search

fabric-community / the-hallow

Fabric Community mod for Hacktoberfest!
MIT License
14 stars 19 forks source link

Add method descriptors to the various mixins. #149

Closed MariaTheDinkus closed 5 years ago

MariaTheDinkus commented 5 years ago

This PR adds descriptors to the various methods in our mixins to ensure that they work properly even when the mod is built. This is the next step on the way to getting built versions of our mod to work properly.

Juuxel commented 5 years ago

Injections don't need the descriptors (usually only @At targets do) unless there are multiple methods with the same name.

MariaTheDinkus commented 5 years ago

I’m aware. This is simply future-proofing at this point. At first I thought it was the cause of our mixins not working.

Overall including descriptors isn’t going to hurt anything.