Correcting mishaps + upgrade tombstone

fabric-community / the-hallow

Fabric Community mod for Hacktoberfest!

MIT License

14 stars 19 forks source link

Correcting mishaps + upgrade tombstone #160

Closed vronc closed 5 years ago

vronc commented 5 years ago

I realized I had crucial changes on the wrong branch for the tombstone I created (the language string was missing + the tombstone was initiated as food made of carpet material..!). :man_facepalming: This PR fixes that.
I also made a fun change: The tombstone is now fertilizable if it's on dirt => some small flowers will appear on top of the grave. This will work even if it's on deceased dirt which goes against principles but I thought it would be fun if a corpse could give some new life to the dirt.

MariaTheDinkus commented 5 years ago

This needs to be updated to use the latest master considering we have recently renamed almost everything in the mod.

vronc commented 5 years ago

I thought I pulled it 🤔 still not an expert I guess...

MariaTheDinkus commented 5 years ago

It's no big deal, but one thing you need to keep in mind is that in the latest master src/main/java/com/fabriccommunity/spookytime is now thehallow at the end. Same for src/main/resources/assets/spookytime. SpookyBlocks has been renamed to HallowedBlocks.

vronc commented 5 years ago

Should be done now.

LemmaEOF commented 5 years ago

@vronc This is looking pretty good! Just make sure you can't bonemeal a tombstone after it's already grown and this is merge-ready!

vronc commented 5 years ago

Done!