search

fabric-community / the-hallow

Fabric Community mod for Hacktoberfest!
MIT License
14 stars 19 forks source link

clean up fluid crafting #180

Closed TwilightFlower closed 5 years ago

TwilightFlower commented 5 years ago

removes a bunch of duplicate code relating to fluid crafting (and a bugfix):

  1. Combines BloodRecipe and WitchWaterRecipe into FluidRecipe

  2. Combines BloodRecipeSerializer and WitchWaterRecipeSerializer into FluidRecipeSerializer

  3. Takes shared crafting-related code from BloodBlock and WitchWaterBlock and moves it into CraftingFluidBlock (which they now both extend)

  4. Prevents mutation of the Recipe's output itemstack (cause of the bug where fluid crafting would randomly stop working)