search

fabric-community / the-hallow

Fabric Community mod for Hacktoberfest!
MIT License
14 stars 19 forks source link

messed up terrain gen with TBO-classic #182

Open spyguy26 opened 4 years ago

spyguy26 commented 4 years ago

when playing with both the hallow and TBO-classic world gen seems to turn striped between hallow biomes and vanilla biomes as pictured in 2019-11-12_18 16 22

to reproduce have both The Hallow and tbo-classic, create a new world (as worlds created without tbo-classic are unaffected) and enter the hallow

fabric loader version: 0.6.4+build.169 fabric api version: fabric-api-0.4.1+build.245-1.14 The Hallow version: TheHallow-1.1.0-beta+1.14.4 Trinkets version: trinkets-2.1.1 Tbo-classic version: tbo-classic-1.0.0

LemmaEOF commented 4 years ago

I believe this would be on tbo-classic's side. It might not be properly checking which dimension it's injecting its biomes into.

spyguy26 commented 4 years ago

all right posted an issue to TBO-Classic's issue tracker here https://github.com/valoeghese/TBOClassic/issues/1#issue-521863830

valoeghese commented 4 years ago

Possibly a byte overflow 🤔

valoeghese commented 4 years ago

Yeah almost definitely a byte overflow. (Thanks for nothing, mojang chunk nbt storage!) If you get spam of unknown biome id in the log that’ll confirm it

valoeghese commented 4 years ago

Though the spam of unknown biome id that I mentioned doesn’t appear in the saved logs if I remember correctly