React Slider drag issues

fabric-ds / issues

Site for tracking tasks and issues related to Fabric

0 stars 0 forks source link

React Slider drag issues #74

Open benct opened 2 years ago

benct commented 2 years ago

Both slider components (regular and range) have some problems when dragging the slider. They seems to call onChange when they are not supposed to (should only be called on drag end(?)).

On desktop, the onChange function is (more often than not) called once on drag start, which makes the slider laggy/jumpy.
On mobile devices, it calls onChange on every drag move, making it almost impossible to use at all.

This behaviour is present in the examples on https://react.fabric-ds.io/slider too, not just in our implementation.

digitalsadhu commented 2 years ago

Fabric CSS v1.1.1 fixes this issue. https://assets.finn.no/pkg/@fabric-ds/css/1.1.1/fabric.min.css

So long as you are doing your builds using the import map https://assets.finn.no/map/fabric/v2 in elk.json then you should be good to go.

Double check that https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css and https://assets.finn.no/pkg/@fabric-ds/css/1.1.1/fabric.min.css are being loaded in the network tab when you run your apps.

benct commented 2 years ago

Great, it definitely works a lot better now 🙂 but as @benja mentioned here, some issues with onChange are still present.

digitalsadhu commented 2 years ago

We've discussed this a bit more and would very much like to take a slight step back to align the implementations between React,Vue,Custom elements. How desperate are you for these fixes @benct ?

benct commented 2 years ago

It would be good to have it fixed for the release of our new flight frontend (probably after easter). But it might not be a showstopper.