fabric-testbed / fabrictestbed-extensions

Extensions for the fabric APUI/CLI.
MIT License
6 stars 12 forks source link

Remove redundant `Node.delete()` #323

Closed sajith closed 4 months ago

sajith commented 4 months ago

Resolves #321. Keeping the second Node.delete(), because I'm pretty sure the first one was never called.

Here's a quick test, since writing a whole test for the actual fablib code would be a chore: running the below snippet with python test.py | uniq only produces delete #2. It appears that the second delete() method shadowed the first.

class Test:
    def delete(self):
        print("delete #1")

    def delete(self):
        print("delete #2")

for i in range(1000):
    t = Test()
    t.delete()

t = Test()
for i in range(1000):
    t.delete()
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8978814744

Details


Totals Coverage Status
Change from base Build 8883235255: -0.008%
Covered Lines: 1159
Relevant Lines: 4697

💛 - Coveralls