Closed niksu closed 3 months ago
@niksu Thank you! Good catches.
Do you think you will be able to sign the commits? FABRIC project policy requires GPG signed commits. Unfortunately we do not have publicly available documentation regarding this policy, as far as I know. I will go ahead and merge this PR if signing commits is a hassle for you.
Totals | |
---|---|
Change from base Build 9008543552: | -0.1% |
Covered Lines: | 1151 |
Relevant Lines: | 4689 |
Thanks @sajith I've signed the commit
@niksu Thank you!
⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (
git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}
) and force push them to this branch (git push --force-with-lease
).If you're new to commit signing, there are different ways to set it up:
Sign commits with
Follow the steps below to set up commit signing with `gpg`: 1. [Generate a GPG key](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key) 2. [Add the GPG key to your GitHub account](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account) 3. [Configure `git` to use your GPG key for commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-gpg-key)gpg
Sign commits with
Follow the steps below to set up commit signing with `ssh-agent`: 1. [Generate an SSH key and add it to `ssh-agent`](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent) 2. [Add the SSH key to your GitHub account](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account) 3. [Configure `git` to use your SSH key for commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key)ssh-agent
Sign commits with 1Password
You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process. Learn how to [use 1Password to sign your commits](https://developer.1password.com/docs/ssh/git-commit-signing/).