search

fabric-testbed / fabrictestbed-extensions

Extensions for the fabric APUI/CLI.
MIT License
7 stars 12 forks source link

341 get device name add error logging and none check #342

Closed kthare10 closed 4 months ago

kthare10 commented 4 months ago

341

Addresses https://learn.fabric-testbed.net/forums/topic/get_device_name-returns-none/ as well as the deprecated function: get_os_interface

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9628455231

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/interface.py 0 14 0.0%
<!-- Total: 0 14 0.0% -->
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/slice.py 1 8.42%
fabrictestbed_extensions/fablib/node.py 2 9.93%
fabrictestbed_extensions/fablib/interface.py 2 17.53%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 9322927172: 3.7%
Covered Lines: 1162
Relevant Lines: 4703
💛 - Coveralls
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9628502953

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/interface.py 0 14 0.0%
<!-- Total: 0 14 0.0% -->
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/interface.py 2 14.51%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9322927172: -0.009%
Covered Lines: 1165
Relevant Lines: 4703
💛 - Coveralls
kthare10 commented 4 months ago

@sajith - not sure if this is related to new CI/CD changes pushed in https://github.com/fabric-testbed/fabrictestbed-extensions/pull/336 All tests pass but 3.10 tests fail to push report somewhere. This seems to be related to github workflows. Could you please take a look at this?

sajith commented 4 months ago

@sajith - not sure if this is related to new CI/CD changes pushed in #336 All tests pass but 3.10 tests fail to push report somewhere. This seems to be related to github workflows. Could you please take a look at this?

Re-running the test worked. I'm certain that it is a transient error that does not involve anything that we do.