fabric-testbed / fabrictestbed-extensions

Extensions for the fabric APUI/CLI.
MIT License
7 stars 12 forks source link

`FacilityPort.show()` errors out #346

Closed sajith closed 1 month ago

sajith commented 4 months ago

Copying the error seen in a notebook:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[4], line 1
----> 1 facility_port.show()

File [~/fabrictestbed-extensions/fabrictestbed_extensions/fablib/facility_port.py:101](https://jupyter.fabric-testbed.net/home/fabric/fabrictestbed-extensions/fabrictestbed_extensions/fablib/facility_port.py#line=100), in FacilityPort.show(self, fields, output, quiet, colors, pretty_names)
     98 def show(
     99     self, fields=None, output=None, quiet=False, colors=False, pretty_names=True
    100 ):
--> 101     data = self.toDict(pretty_names=True)
    103     # fields = ["Name",
    104     #         ]
    106     if pretty_names:

TypeError: FacilityPort.toDict() got an unexpected keyword argument 'pretty_names'

Seems the fix should be trivial. But I have not been able to properly test FacilityPort.show(), because of errors when creating a slice using the example notebook (see below, with some wrapping added in the message text for better readability), so just leaving this issue report for now.

failed lease update- all units failed priming: Exception during create for unit: 29b8f104-098c-4ca5-8c07-8352a217a4a3 
Playbook has failed tasks: NSO commit returned JSON-RPC error: type: rpc.method.failed, code: -32000, message: Method failed, 
data: message: External error in the NED implementation for device star-data-sw: Fri Jun 28 18:28:25.571 UTCrnrn
Failed to commit one or more configuration items during a pseudo-atomic operation. All changes made have been reverted.rn
SEMANTIC ERRORS: This configuration was rejected by rn the system due to semantic errors.
The individual rn errors with each failed configuration command can be rn found below.rnrnrnl2vpnrn bridge
group bg-net_facility_por-29b8f104-09rn bridge-domain bd-net_facility_por-29b8f10rn interface HundredGigE0/0/0/30.3309rn
Invalid argument: Interface already used for L2VPNrn rn rn rnrnend, internal: jsonrpc_tx_commit357#all units failed priming:
Exception during create for unit: 29b8f104-098c-4ca5-8c07-8352a217a4a3 
Playbook has failed tasks: NSO commit returned JSON-RPC error: type: rpc.method.failed, code: -32000, message: Method failed, 
data: message: External error in the NED implementation for device star-data-sw: Fri Jun 28 18:28:25.571 UTCrnrn 
Failed to commit one or more configuration items during a pseudo-atomic operation. 
All changes made have been reverted.rn 
SEMANTIC ERRORS: This configuration was rejected by rn the system due to semantic errors. 
The individual rn errors with each failed configuration command can be rn found below.rnrnrnl2vpnrn bridge group 
bg-net_facility_por-29b8f104-09rn bridge-domain bd-net_facility_por-29b8f10rn interface HundredGigE0/0/0/30.3309rn
 Invalid argument: Interface already used for L2VPNrn rn rn rnrnend, internal: jsonrpc_tx_commit357#