Closed scauligi closed 1 month ago
⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}
) and force push them to this branch (git push --force-with-lease
).
If you're new to commit signing, follow the steps below to set up commit signing with gpg
:
@scauligi - Could you please sign your commits using the steps indicated above?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
fabrictestbed_extensions/fablib/slice.py | 0 | 1 | 0.0% | ||
<!-- | Total: | 0 | 1 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 10048084488: | 0.0% |
Covered Lines: | 1350 |
Relevant Lines: | 5585 |
This change was pushed via https://github.com/fabric-testbed/fabrictestbed-extensions/pull/353 So closing this PR.
Looks like a simple logic bug, the original code was gating
post_boot_config()
behindadvance_allocation
instead ofnot advance_allocation