fabric-testbed / fabrictestbed-extensions

Extensions for the fabric APUI/CLI.
MIT License
6 stars 12 forks source link

bugfix: new slices not running post_boot_config() on submit #354

Closed scauligi closed 1 month ago

scauligi commented 1 month ago

Looks like a simple logic bug, the original code was gating post_boot_config() behind advance_allocation instead of not advance_allocation

github-actions[bot] commented 1 month ago

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
kthare10 commented 1 month ago

@scauligi - Could you please sign your commits using the steps indicated above?

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10048147937

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/slice.py 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build 10048084488: 0.0%
Covered Lines: 1350
Relevant Lines: 5585

💛 - Coveralls
kthare10 commented 1 month ago

This change was pushed via https://github.com/fabric-testbed/fabrictestbed-extensions/pull/353 So closing this PR.