Change the server's download location

[ljelinkova]

At the moment, the LSP server is downloaded from this repository:

https://github.com/invinciblejai/fabric8-analytics-lsp-server/archive/test-devstudio.zip

I think it should be moved to jboss site.

WDYT @nickboldt @invincibleJai @GeetikaBatra

[geetikabatra]

@ljelinkova , + 1

[invincibleJai]

@GeetikaBatra we should use https://github.com/fabric8-analytics/fabric8-analytics-lsp-server instead as it's the main repo. https://github.com/invinciblejai/fabric8-analytics-lsp-server/archive/test-devstudio.zip we used to test lsp flow.

CC @ljelinkova @samuzzal-choudhury @nickboldt

[geetikabatra]

@invincibleJai, are the latest changes visible in https://github.com/fabric8-analytics/fabric8-analytics-lsp-server ?

[invincibleJai]

@GeetikaBatra yes , but you need to test once with that.

[nickboldt]

So you want to publish builds of https://github.com/invinciblejai/fabric8-analytics-lsp-server/ to download.jboss.org ? Do you need help setting up a Jenkins build? I can clone https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/devstudio_master/job/jbosstools-fabric8analytics_master/ and point it at this new repo to build the upstream requirement.

[geetikabatra]

@invincibleJai , Looks like https://github.com/fabric8-analytics/fabric8-analytics-lsp-server doesn't work. I still get the following error.

  Types of property 'consume' are incompatible.
    Type '(token: IToken<string>) => void' is not assignable to type '<T>(token: IToken<T>) => void'.
src/json.ts(118,31): error TS2345: Argument of type 'this' is not assignable to parameter of type 'IJsonParserScope'.
  Type 'Scope' is not assignable to type 'IJsonParserScope'.
    Types of property 'consume' are incompatible.
      Type '(token: IToken<string>) => void' is not assignable to type '<T>(token: IToken<T>) => void'.
        Types of parameters 'token' and 'token' are incompatible.
          Type 'IToken<T>' is not assignable to type 'IToken<string>'.
            Type 'T' is not assignable to type 'string'.
src/json.ts(200,42): error TS2345: Argument of type 'Scope' is not assignable to parameter of type 'IJsonParserScope | Thenable<IJsonParserScope>'.
  Type 'Scope' is not assignable to type 'Thenable<IJsonParserScope>'.
    Property 'then' is missing in type 'Scope'.

[invincibleJai]

Thanks @nickboldt yes i do need to set up a jenkins build but for https://github.com/fabric8-analytics/fabric8-analytics-lsp-server, it's in my plate :)

[invincibleJai]

@GeetikaBatra need to debug it , let's look into this in office

[invincibleJai]

@GeetikaBatra test with master https://github.com/fabric8-analytics/fabric8-analytics-lsp-server should be working now

[geetikabatra]

@nickboldt, I don't think we would need to publish the builds of https://github.com/invinciblejai/fabric8-analytics-lsp-server/ to download.jboss.org . This is downloaded and used. Does publishing it , a better solution than downloading it in the server directory of the project?

[invincibleJai]

@GeetikaBatra try with https://github.com/fabric8-analytics/fabric8-analytics-lsp-server , and we do make release https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/releases/ but it's manual ATM , once get some time will look into this.

[ljelinkova]

Do you think it will be possible to make a release of LSP server until the code freeze of DevStudio (25. Oct)?

[nickboldt]

Yes, entirely possible.

Here's a job in progress I started moments ago. I'm not sure how you want to build this, or what you want to archive/publish, but I've made some guesses as a starting place.

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-fabric8analytics-lsp-server_master/

If you can confirm that you want me to run make-tarball.sh https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/blob/master/make-tarball.sh and then publish the tar as a gz or xz archive, I can set that up next in the job.

On Wed, Oct 11, 2017 at 8:07 AM, Lucia Jelinkova notifications@github.com wrote:

Do you think it will be possible to make a release of LSP server until the code freeze of DevStudio (25. Oct)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/48#issuecomment-335788377, or mute the thread https://github.com/notifications/unsubscribe-auth/AAN5DSrCckQuOeC-Oq9pYVfRrr9apiYuks5srK-ZgaJpZM4PuqsI .

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com https://red.ht/sig TRIED. TESTED. TRUSTED. https://redhat.com/trusted @ @redhatnews https://twitter.com/redhatnews Red Hat https://www.facebook.com/RedHatInc

[nickboldt]

Job completed. You can now build, gzip the tarball, rename it based on a parameter in the job (VERSION = 0.0.6-SNAPSHOT), and deploy to this folder: http://download.jboss.org/jbosstools/oxygen/snapshots/builds/jbosstools- fabric8analytics-lsp-server_master/

If you want to deploy somewhere else the job could even be configured to push to another location that supports rsync over ssh.

Once this PR [1] is merged, the job can be switched to run from origin/master instead of my fork.

[1] https://github.com/fabric8-analytics/fabric8- analytics-lsp-server/pull/18

Note too that the job should check github for changes every 3 hours. If that's too frequent / not frequent enough, it's easy enough to fix that -- just tell me what frequency you want instead.

Cheers,

Nick

On Wed, Oct 11, 2017 at 9:57 AM, Nick Boldt nboldt@redhat.com wrote:

Yes, entirely possible.

Here's a job in progress I started moments ago. I'm not sure how you want to build this, or what you want to archive/publish, but I've made some guesses as a starting place.

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com /job/jbosstools-fabric8analytics-lsp-server_master/

If you can confirm that you want me to run make-tarball.sh https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/blob/master/make-tarball.sh and then publish the tar as a gz or xz archive, I can set that up next in the job.

On Wed, Oct 11, 2017 at 8:07 AM, Lucia Jelinkova <notifications@github.com

wrote:

Do you think it will be possible to make a release of LSP server until the code freeze of DevStudio (25. Oct)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/48#issuecomment-335788377, or mute the thread https://github.com/notifications/unsubscribe-auth/AAN5DSrCckQuOeC-Oq9pYVfRrr9apiYuks5srK-ZgaJpZM4PuqsI .

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com https://red.ht/sig TRIED. TESTED. TRUSTED. https://redhat.com/trusted @ @redhatnews https://twitter.com/redhatnews Red Hat https://www.facebook.com/RedHatInc

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com https://red.ht/sig TRIED. TESTED. TRUSTED. https://redhat.com/trusted @ @redhatnews https://twitter.com/redhatnews Red Hat https://www.facebook.com/RedHatInc

[nickboldt]

Here's a fix for being unable to gunzip the tarball:

https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/pull/19

[ljelinkova]

I got lost between the responsibilities of @nickboldt and @invincibleJai so I'll sum up what we need for the plugin and please answer or advice where necessary

1. the plugin should be built with released (presumably 0.0.6) version of LSP server so that the build is repeatable with the same results.
2. the built server should be uploaded somewhere so that we can download it during build. The URL should not change.
3. we've got difficulties using .tar file in maven build (previously there was a zip file) @nickboldt what maven plugin should be used to unpack tar file?

[invincibleJai]

@ljelinkova @GeetikaBatra just to update , @nickboldt have automated the build process on each merge to master of LSP repo, it will generate a tar and which is being hosted now , that can be downloaded by this extension during build. ( @nickboldt correct me if am wrong , Nick can update on exact url and version)

As earlier in extension zip(which is LSP code) is being used so some node (NPM) tasks were needed to run to build LSP code which won't be needed any more with tar, just it needs to unpack tar and can be used.

If post unpack tar you face some issue , please let me know. We are following similar approach for VSCode extension with lsp

[geetikabatra]

@invincibleJai, the tar which lsp server is creating throwsInvalid byte 105 at offset 0 in 'i)L�v��b��\' len=12 . Any idea how can this be resolved. If we zip the file instead of gunzipping(.zip extension instead of tar.gz). Would it work?

[invincibleJai]

@GeetikaBatra am not sure what is wrong need to look into but currently i guess Nick using *.tar not .tar.gz . you need to unpack tar if you are doing it properly i don't think there should be any problem as even am using it same way.

[geetikabatra]

@invincibleJai, it is .tar right now, before this fix fabric8-analytics/fabric8-analytics-lsp-server#19, it was gunzip(.tar.gz). But both of them are not working for me.

[geetikabatra]

This is covered by https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/pull/79 and https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/pull/94