search

fabric8-analytics / fabric8-analytics-license-analysis

License Analysis
GNU General Public License v3.0
6 stars 25 forks source link

Replace auth code with auth library #130

Closed humaton closed 5 years ago

humaton commented 6 years ago

Replace authentication code by shared library

centos-ci commented 6 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

centos-ci commented 6 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

centos-ci commented 6 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

sunilk747 commented 5 years ago

@humaton Did you test it locally. Is it working for you?

humaton commented 5 years ago

@sunilk747 I run tests.

sunilk747 commented 5 years ago

@humaton I fetch your PR and tried testing it locally, for me it's not working and also I am not getting a proper error message with status code. llllllll

humaton commented 5 years ago

The weirdest thing is that tests are passing.

humaton commented 5 years ago

So it seems that the problem is somewhere else. I can run the project locally and api response is: { "status": "ok" }

sunilk747 commented 5 years ago

DId you try this endpoint license-recommender because this is the one which uses auth service.

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

humaton commented 5 years ago

Yes and it seems that error handling in this project is kicking in. If I check logs I can see 401 but the API returns 500

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

humaton commented 5 years ago

[TEST]

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

sunilk747 commented 5 years ago

[test]

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

centos-ci commented 5 years ago

@humaton Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-130

humaton commented 5 years ago

@sunilk747 can you please retest this?

sunilk747 commented 5 years ago

When I am testing it with prod token it's not working for me but now it's showing a proper error message. Tests are passing as well.