Codecov Report

:exclamation: No coverage uploaded for pull request base (master@34b6843). Click here to learn what that means. The diff coverage is 80%.

@@            Coverage Diff            @@
##             master     #204   +/-   ##
=========================================
  Coverage          ?   93.49%           
=========================================
  Files             ?        9           
  Lines             ?      830           
  Branches          ?        0           
=========================================
  Hits              ?      776           
  Misses            ?       54           
  Partials          ?        0

Impacted Files	Coverage Δ
src/license_analysis.py	`99.64% <80%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34b6843...e77a987. Read the comment docs.

centos-ci commented 5 years ago

@yzainee Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-license-analysis:SNAPSHOT-PR-204

yzainee-zz commented 5 years ago

I checked few links for open source license, compatibility etc, everywhere it shows gplv3 and gplv3+ together https://dwheeler.com/essays/floss-license-slide.html https://janelia-flyem.github.io/licenses.html All GPLv3 are GPLV3+ compliant as well. so even if we take gplv3+ as the license, its not going to cause any problems with out analysis. The compatible license for the project is not going to change due to this @miteshvp

Also checked https://en.wikipedia.org/wiki/GNU_General_Public_License https://www.gnu.org/licenses/gpl-3.0.en.html

miteshvp commented 5 years ago

My only concern is, if the stack license can be GPLv-3, it should not end at GPL-v3+. If you're ok with this, then I am all ok

fabric8-analytics / fabric8-analytics-license-analysis

License bug #204

Codecov Report