search

fabric8-analytics / fabric8-analytics-license-analysis

License Analysis
GNU General Public License v3.0
6 stars 25 forks source link

Wrong sanity check test #69

Closed tisnik closed 6 years ago

tisnik commented 6 years ago

Test for the misplaced sanity check. The check is placed at line 107:

https://github.com/fabric8-analytics/fabric8-analytics-license-analysis/blob/master/src/stack_license.py#L107

But it must be performed anywhere before line 102 (+ would be better to check for the presence of 'packages' entry):

https://github.com/fabric8-analytics/fabric8-analytics-license-analysis/blob/master/src/stack_license.py#L102

So -> the test failure is expected here