fabric8-analytics / fabric8-analytics-license-analysis

License Analysis
GNU General Public License v3.0
6 stars 25 forks source link

Modified API end point to pick the present license from license file #71

Closed animuk closed 6 years ago

centos-ci commented 6 years ago

Can one of the admins verify this patch?

centos-ci commented 6 years ago

Can one of the admins verify this patch?

centos-ci commented 6 years ago

Can one of the admins verify this patch?

centos-ci commented 6 years ago

Can one of the admins verify this patch?

sara-02 commented 6 years ago

[test]

sara-02 commented 6 years ago

@animuk the pylinter failed because of the following issue:

src/rest_api.py:27:1: W293 blank line contains whitespace
src/rest_api.py:30:1: E303 too many blank lines (3)
src/rest_api.py:45:1: W293 blank line contains whitespace
src/rest_api.py:63:5: E303 too many blank lines (2)

And the Doc-string checker failed because of the following issue:

src/rest_api.py
src/rest_api.py:43 in public function `stack_license`:
        D202: No blank lines allowed after function docstring (found 1)
1
    Fail

Kindly apply a fix

Also, two tests are failing, you can check it here: https://ci.centos.org/job/devtools-fabric8-analytics-license-analysis-fabric8-analytics/91/console However, the tests are passing on my local, when I ran ./runtests.sh :/

tisnik commented 6 years ago

It's kinda strange to read the synonyms from the test files. If you think this file contains an official database, it would be better to move it outside test directory (then you'd need to change configuration on several places, but it is not that hard).

Also - what's the purpose of this change? It breaks our internal API so changes will be required in all clients as well, right?

And, please make sure you rebase this branch and run new unit tests (some newest unit test will be broken by this change ;)

sunilk747 commented 6 years ago

Closing this PR. As this case is handled in this PR - https://github.com/fabric8-analytics/fabric8-analytics-server/pull/276