search

fabric8-analytics / fabric8-analytics-license-analysis

License Analysis
GNU General Public License v3.0
6 stars 25 forks source link

[MRG -1] Fix CI unit test run #83

Closed rootAvish closed 6 years ago

rootAvish commented 6 years ago

Need to install GCC on Centos-CI, re-add the missing requirements and voila!

abs51295 commented 6 years ago

I think it should work now ;) 🎉

centos-ci commented 6 years ago

@rootAvish Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/license-analysis:SNAPSHOT-PR-83

tisnik commented 6 years ago

@rootAvish do you want to merge just the fix, or the auth code? I think that the auth.code (+utils etc. etc.) would need more work (unit tests etc.). Probably better to split this PR?

rootAvish commented 6 years ago

@tisnik I don't want to get this merged, that's why I added the [MRG -1] 🙂 I've kept it up for @sunilk747 to look over and continue working on, if the build changes are required independent of #80 as well I can open a separate PR otherwise @sunilk747 can incorporate them as a part of #80 itself since the discussions around the code have all happened in that thread.

tisnik commented 6 years ago

cool, thank you @rootAvish

rootAvish commented 6 years ago

Closing in favor of #80 being merged.