search

fabric8-analytics / fabric8-analytics-license-analysis

License Analysis
GNU General Public License v3.0
6 stars 25 forks source link

change license API resposne #87

Closed sunilk747 closed 6 years ago

centos-ci commented 6 years ago

@sunilk747 Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/license-analysis:SNAPSHOT-PR-87

ravsa commented 6 years ago

let's wait for the build to finish

centos-ci commented 6 years ago

@sunilk747 Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/license-analysis:SNAPSHOT-PR-87

miteshvp commented 6 years ago

@sunilk747 with the change in response, and addition of new endpoint, it will be good if you can update the README as well.

ravsa commented 6 years ago

@miteshvp It was a bug, distinct licenses were showing multiple times.

miteshvp commented 6 years ago

@ravsa, we did change the response due to dep-editor work. And with the addition of new endpoint, it needs to be updated in README as well. And of course, there are no unit-tests to support this use-case. @sunilk747 please make sure all these things are handled

sunilk747 commented 6 years ago

@miteshvp Yes. Currently working on adding the unit test for the added endpoints