search

fabric8-analytics / fabric8-analytics-lsp-server

Apache License 2.0
9 stars 33 forks source link

fix(rls): Update README to include test section #105

Closed arajkumar closed 5 years ago

centos-ci commented 5 years ago

Can one of the admins verify this patch?

arajkumar commented 5 years ago

@invincibleJai , I see that the new fabric8-analytics-lsp-server npm module has been published(with #103). What is the procedure to get that into vscode extension? From the log I'm assuming that having a commit with "fix(rls)" would do the work.

invincibleJai commented 5 years ago

[test]

invincibleJai commented 5 years ago

@arajkumar yes, any semantic commit would trigger an npm release. Then can file a PR to update https://github.com/fabric8-analytics/fabric8-analytics-vscode-extension/blob/master/package.json#L192

arajkumar commented 5 years ago

@invincibleJai, also i see that /test is not being honoured. Something wrong the CI configuration?

invincibleJai commented 5 years ago

nope i verified on both of ur PRs. It's [test]

see here on dummy PR https://github.com/fabric8-analytics/fabric8-analytics-lsp-server/pull/106

Previous Runs here :

arajkumar commented 5 years ago

@invincibleJai , I don't see any PR from cenosci for fabric8-analytics-vscode-extension to update the lsp version.

invincibleJai commented 5 years ago

That used to work, you can fix it if not working. But again i never went with automated PRs as i need to test and verify so usually filled on my own