codeAction returns command which does seems to be supported by all LSP implementations

fabric8-analytics / fabric8-analytics-lsp-server

Apache License 2.0

9 stars 33 forks source link

codeAction returns command which does seems to be supported by all LSP implementations #95

Closed jeffmaury closed 5 years ago

jeffmaury commented 5 years ago

code fixes are implemented as code actions and current implementation returns commands instead of code actions. This seems not equaly supported by LSP implementations (at least by intellij-lsp) so could be nice to return code actions instead of commands

jeffmaury commented 5 years ago

As this is a substancial change, it's important to validate all environments so I list them so that we can check them

[x] VSCode
[ ] Eclipse / JBoss Tools
- [ ] IntelliJ

invincibleJai commented 5 years ago

@jeffmaury for VSCode we needed to handle the command in client in order to apply fixes as in https://github.com/fabric8-analytics/fabric8-analytics-vscode-extension/blob/master/src/extension.ts#L28-L42.

With code actions implementation, does client needs to hand it as was the case for command as above

jeffmaury commented 5 years ago

No with my PR you don't need to register a command anymore