search

fabric8-analytics / fabric8-analytics-server

fabric8-analytics API server
Apache License 2.0
16 stars 56 forks source link

[On-HOLD] feat: Ignore vulnerability feature for VA #817

Open AkshayBhansali18 opened 3 years ago

AkshayBhansali18 commented 3 years ago

Ignore vulnerability feature for VA with test cases

codecov-commenter commented 3 years ago

Codecov Report

Merging #817 (d32d5c4) into master (a8c33bc) will decrease coverage by 0.13%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   79.33%   79.19%   -0.14%     
==========================================
  Files          21       21              
  Lines        1679     1692      +13     
==========================================
+ Hits         1332     1340       +8     
- Misses        347      352       +5
Impacted Files Coverage Δ
bayesian/utility/v2/component_analyses.py 90.00% <61.53%> (-1.83%) :arrow_down:
bayesian/api/api_v2.py 74.47% <100.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8c33bc...d32d5c4. Read the comment docs.

rafiu007 commented 3 years ago

@jparsai Do we really need this for VA? VA is very specific for clair.

jparsai commented 3 years ago

@rafiu007 Dont we want to ignore in Clair?

rafiu007 commented 3 years ago

@rafiu007 Dont we want to ignore in Clair?

I cant think of a use case where we would like to ignore. By default clair serves all packages

jparsai commented 3 years ago

Okay, for now we can keep this PR open, later if Clair requires ignore feature we can take this PR in.