add pull secret to openshift manifest

fabric8-analytics / fabric8-analytics-worker

fabric8-analytics worker for gathering raw data

GNU General Public License v3.0

8 stars 45 forks source link

add pull secret to openshift manifest #951

Closed maorfr closed 3 years ago

maorfr commented 3 years ago

part of https://issues.redhat.com/browse/APPSRE-3082

this PR adds a ServiceAccount to the deployment manifest so that the pods can pull a private image. the pull secret is currently associated to the default ServiceAccount, and that is not a good practice.

maorfr commented 3 years ago

actually we'll probably need to do something different due to all the yaml anchoring in https://github.com/openshiftio/saas-analytics/blob/master/bay-services/worker.yaml

EDIT: ignore this. please review :)

maorfr commented 3 years ago

i'm going to merge this as we are currently migrating in https://coreos.slack.com/archives/C01DKUK9P1A/p1614152512012100