search

fabric8-launcher / launcher-booster-catalog-service

Service classes for the booster catalog
Apache License 2.0
2 stars 10 forks source link

Dirty NPE in NativeGitBoosterCatalogPathProvider.createBoosterContentPath #46

Open ia3andy opened 6 years ago

ia3andy commented 6 years ago

the code in NativeGitBoosterCatalogPathProvider.createBoosterContentPath can be dangerous booster.getGitRepo() and booster.getGitRef() are both @Nullable and can lead to a dirty ProcessBuilder NPE.

Caused by: java.lang.NullPointerException
    at java.lang.ProcessBuilder.start(ProcessBuilder.java:1012)
    at io.fabric8.launcher.booster.catalog.spi.NativeGitBoosterCatalogPathProvider.createBoosterContentPath(NativeGitBoosterCatalogPathProvider.java:89)
    at io.fabric8.launcher.booster.catalog.AbstractBoosterCatalogService.lambda$fetchBoosterContent$4(AbstractBoosterCatalogService.java:194)
    ... 9 more
ia3andy commented 6 years ago

it seems to happen with an invalid/outdated catalog