search

fabric8-launcher / launcher-booster-catalog

The Booster Catalog used by developers.redhat.com/launch
https://developers.redhat.com/launch
Apache License 2.0
14 stars 54 forks source link

Removing all directories and files related to the old format #373

Closed quintesse closed 5 years ago

quintesse commented 5 years ago

@gastaldi what shall we do with the CODEOWNERS file? Just turn the access to *? Or do we remove it?

gastaldi commented 5 years ago

@quintesse in this case I believe the best is to remove it. No sense in keeping it since everything is in one big file now

quintesse commented 5 years ago

@gastaldi ok, but doesn't the CODEOWNERS file also give all of them the rights to review and approve PRs etc?

gastaldi commented 5 years ago

That's something that now will need to be removed from the PR process. I don't see how would CODEOWNERS work with a single file

quintesse commented 5 years ago

I know it won't work to only allow people to edit their own stuff, but I was wondering if it could still give some other advantages, like for example that all get notified to review the changes made by others. But if you say there's no use than we just remove it.