Closed jacobdotcosta closed 4 years ago
[test]
Btw @jacobdotcosta , you don't need to open a new PR. You can just re-do your changes, do a git commit --amend
and then force-push. Or just add the changes in new commits and I'll squash them into a single commit, no problem. :-)
Btw @jacobdotcosta , you don't need to open a new PR. You can just re-do your changes, do a
git commit --amend
and then force-push. Or just add the changes in new commits and I'll squash them into a single commit, no problem. :-)
@quintesse that actually is produced by automation so it's easier to close a PR and re-create one than edit an existing one most of the time ;)
@quintesse Is it normal that the tests are failing because they're not resolving prod versions of our artifacts which are not supposed to be on Maven Central?
@quintesse Is it normal that the tests are failing because they're not resolving prod versions of our artifacts which are not supposed to be on Maven Central?
No idea TBH. Not sure if jobs on the centos ci should automatically have access to prod bits?
It is quite normal. Why would you want the Launcher to serve examples that don't work?
It is quite normal. Why would you want the Launcher to serve examples that don't work?
@Ladicek Care to elaborate? The bits are available on MRRC, just not on Central.
Ah, sorry, missed that! In that case, no, that test should pass. Hmm, unless for some reason, you removed the MRRC declarations from those POMs, perhaps?
Ah, sorry, missed that! In that case, no, that test should pass. Hmm, unless for some reason, you removed the MRRC declarations from those POMs, perhaps?
That's indeed what's going on, unfortunately. I got the same hunch that you did and checked and, indeed, the MRRC definition got removed… 😭
Aaaand the test proves useful :grin:
Can one of the admins verify this patch?