search

fabric8-launcher / launcher-booster-catalog

The Booster Catalog used by developers.redhat.com/launch
https://developers.redhat.com/launch
Apache License 2.0
14 stars 54 forks source link

Update Spring Boot to 2.2.6.RELEASE #392

Closed jacobdotcosta closed 4 years ago

centos-ci commented 4 years ago

Can one of the admins verify this patch?

quintesse commented 4 years ago

[test]

quintesse commented 4 years ago

Btw @jacobdotcosta , you don't need to open a new PR. You can just re-do your changes, do a git commit --amend and then force-push. Or just add the changes in new commits and I'll squash them into a single commit, no problem. :-)

metacosm commented 4 years ago

Btw @jacobdotcosta , you don't need to open a new PR. You can just re-do your changes, do a git commit --amend and then force-push. Or just add the changes in new commits and I'll squash them into a single commit, no problem. :-)

@quintesse that actually is produced by automation so it's easier to close a PR and re-create one than edit an existing one most of the time ;)

metacosm commented 4 years ago

@quintesse Is it normal that the tests are failing because they're not resolving prod versions of our artifacts which are not supposed to be on Maven Central?

quintesse commented 4 years ago

@quintesse Is it normal that the tests are failing because they're not resolving prod versions of our artifacts which are not supposed to be on Maven Central?

No idea TBH. Not sure if jobs on the centos ci should automatically have access to prod bits?

Ladicek commented 4 years ago

It is quite normal. Why would you want the Launcher to serve examples that don't work?

metacosm commented 4 years ago

It is quite normal. Why would you want the Launcher to serve examples that don't work?

@Ladicek Care to elaborate? The bits are available on MRRC, just not on Central.

Ladicek commented 4 years ago

Ah, sorry, missed that! In that case, no, that test should pass. Hmm, unless for some reason, you removed the MRRC declarations from those POMs, perhaps?

metacosm commented 4 years ago

Ah, sorry, missed that! In that case, no, that test should pass. Hmm, unless for some reason, you removed the MRRC declarations from those POMs, perhaps?

That's indeed what's going on, unfortunately. I got the same hunch that you did and checked and, indeed, the MRRC definition got removed… 😭

Ladicek commented 4 years ago

Aaaand the test proves useful :grin: