search

fabric8-launcher / launcher-openshift-templates

OpenShift Templates for the Fabric8 Launcher application
http://launcher.fabric8.io
Apache License 2.0
5 stars 17 forks source link

wrong application association in v9 of template #24

Closed rdruss closed 7 years ago

rdruss commented 7 years ago

I installed v9 of the template to install Launch locally on minishift and it seemed to link the backend URL as the application URL at the top of the OpenShift console. This obviously does not work. I could still scroll down and launch explicitly from the launchpad-nginx service, but this does not match the instructions of step 11 of section 4.2

launchpad
gastaldi commented 7 years ago

@quintesse I think the backend doesn't need to be exposed externally with nginx in place, right?

gastaldi commented 7 years ago

Same with Missioncontrol

rdruss commented 7 years ago

Yeah, I was thinking the same thing about MissionControl, @gastaldi. I had accidentally clicked on the exposed URL for MissionControl and was definitely confused by that UI. ;-)

gastaldi commented 7 years ago

https://github.com/openshiftio/launchpad-templates/blob/master/openshift/launchpad-template.yaml#L342 and https://github.com/openshiftio/launchpad-templates/blob/master/openshift/launchpad-template.yaml#L435 must go