search

fabric8-launcher / launcher-openshift-templates

OpenShift Templates for the Fabric8 Launcher application
http://launcher.fabric8.io
Apache License 2.0
5 stars 17 forks source link

Add `app: fabric8-launcher` labels #34

Closed quintesse closed 6 years ago

quintesse commented 6 years ago

Investigate if we should be adding app: fabric8-launcher labels to all the different components. (The idea being it should be possible to delete the entire application in one go using a selector)

gastaldi commented 6 years ago

I thought that was created automatically in OpenShift when you deploy it to an existing OpenShift project

quintesse commented 6 years ago

Ok, so the thing is that it's hard to make sure that all template objects have the correct label (mainly because they get generated by different parts of the build process). Some can be manually added, but it makes it all more fiddly. So I finally decided to just add an extra label called booster that gets the name of the booster. That way if you add several boosters to a single project you'll be able to delete most of a booster by using that label. Anything that's left should be delatable using the app label. It's not perfect but I don't think it's worth the effort in getting it 100% right. (If someone complains about it in the future we can always take another look). Closing.