fabric8-launcher / launcher-openshift-templates

OpenShift Templates for the Fabric8 Launcher application
http://launcher.fabric8.io
Apache License 2.0
5 stars 17 forks source link

Add SENTRY_DSN to the unified template #36

Closed gastaldi closed 6 years ago

gastaldi commented 6 years ago

The launcher-backend has an integration on Sentry.io. To enable it, it requires the SENTRY_DSN var to be defined.

Reference: https://docs.sentry.io/clients/java/config/

quintesse commented 6 years ago

This probably needs a bit more information? Because the link to the config is pretty generic, it doesn't really explain what the URL should be that has to be configured?

gastaldi commented 6 years ago

The DSN is available inside the Sentry UI, under Project Settings -> Client Keys (DSN). See an example here: https://errortracking.prod-preview.openshift.io/openshift_io/fabric8-launcher-backend/settings/keys/

It has a structure similar to:

https://user:pass@errortracking.prod-preview.openshift.io/22?environment=production&stacktrace.app.packages=
quintesse commented 6 years ago

Ok, so how would we get that value into the template?

gastaldi commented 6 years ago

Probably as a Configmap value, as it is done in https://github.com/fabric8-launcher/launcher-backend/blob/e818c0b73dab3fee379cac99868fddff9acb118e/openshift/template.yaml#L145

quintesse commented 6 years ago

Ok, so you're saying that people would install the template and then manually update the SENTRY_DNS value with the correct value?

quintesse commented 6 years ago

But wait, if it's already in the backend template why do you need it in the unified template? It should already be there (unless you forgot to run scripts/create-unified-template.sh after making that change to the backend template ;) )

Ok, so this is just running that script. Let me do that now.

gastaldi commented 6 years ago

Yeah, or configure Sentry first and then add the DSN there, maybe it should be a parameter in the template too

gastaldi commented 6 years ago

I was unaware of that script. Thanks

quintesse commented 6 years ago

ok, I see you made changes that are not compatible with the unified template, I first need to fix that

ia3andy commented 6 years ago

This seems to be already fixed. After recent changes, the configmap key are now