Clarify template documentation

ALRubinger commented 5 years ago

Fabric8 Launch (Frontend + Backend) > OpenShift Application Launcher
Your GitHub Mission Control access token > Your GitHub personal access token (set at https://github.com/settings/tokens)
The Git repository description to be used by Launcher (defaults to Generated by the Red Hat Developer Launch (https://developers.redhat.com/launch)) > The Git repository description to be used by Launcher (defaults to "Generated by the Red Hat Developer Launcher (https://developers.redhat.com/launch))"

gastaldi commented 5 years ago

@ALRubinger what's the difference in the last bullet point?

gastaldi commented 5 years ago

@ALRubinger what's the difference in the last bullet point?

Ah, the double quotes, nvm

ALRubinger commented 5 years ago

@gastaldi And "Launcher" instead of "Launch". I am prepping a PR for these simple changes now.

Man, this template has grown in configgy things :D

gastaldi commented 5 years ago

@ALRubinger remember to just change what's in openshift/split/ and then run

scripts/create-unified-template.sh > openshift/launcher-template.yaml

to generate the unified template

ALRubinger commented 5 years ago

I have updated the split scripts but receive error when generating the unified one:

✔ ~/business/jboss/git/fabric8-launcher/launcher-openshift-templates [master|✚ 2] 
13:58 $ scripts/create-unified-template.sh > openshift/launcher-template.yaml
scripts/create-unified-template.sh: line 34: /home/alr/business/jboss/git/fabric8-launcher/launcher-openshift-templates/scripts/../../launcher-creator-backend/openshift/template.yaml: No such file or directory
scripts/create-unified-template.sh: line 34: /home/alr/business/jboss/git/fabric8-launcher/launcher-openshift-templates/scripts/../../launcher-frontend/openshift/template.yaml: No such file or directory
scripts/create-unified-template.sh: line 61: /home/alr/business/jboss/git/fabric8-launcher/launcher-openshift-templates/scripts/../../launcher-creator-backend/openshift/template.yaml: No such file or directory
scripts/create-unified-template.sh: line 61: /home/alr/business/jboss/git/fabric8-launcher/launcher-openshift-templates/scripts/../../launcher-frontend/openshift/template.yaml: No such file or directory

My commit to fix this is in 8f04b40; leaving it to the team to merge in with the unified stuff. :)

gastaldi commented 5 years ago

@alrubinger you need to git clone the launcher repositories in the same level for that to work.

gastaldi commented 5 years ago

Btw is it Red Hat Application Launcher or OpenShift Application Launcher? I am confused

ALRubinger commented 5 years ago

I switched it up to Red Hat Application Launcher because I felt that was most descriptive for now, but hey, this may be made more clear after a branding exercise.

ALRubinger commented 5 years ago

@ALRubinger you need to git clone the launcher repositories in the same level for that to work.

Hm, that does fix the errors, but running the script gives me many more diffs than I am expecting given the changes I have made.

ALRubinger commented 5 years ago

@ALRubinger you need to git clone the launcher repositories in the same level for that to work.

Hm, that does fix the errors, but running the script gives me many more diffs than I am expecting given the changes I have made.

Nevermind. :) Updated everything locally and all's looking good. PR coming.

ALRubinger commented 5 years ago

PR in #45.

fabric8-launcher / launcher-openshift-templates

Clarify template documentation #44