search

fabric8-launcher / launcher-openshift-templates

OpenShift Templates for the Fabric8 Launcher application
http://launcher.fabric8.io
Apache License 2.0
5 stars 17 forks source link

Install script gives me no launcher creator #54

Closed ALRubinger closed 5 years ago

ALRubinger commented 5 years ago

Ran:

$ curl -s https://raw.githubusercontent.com/fabric8-launcher/launcher-openshift-templates/master/scripts/minishift/install.sh | bash
This script will install the Launcher in Minishift. Make sure that:

- Minishift is running
- You have run oc login previously
- Your GitHub Username is correct [found from git config github.user]: alrubinger
- Your GitHub Token is correct [found from git config github.token]: *REDACTED*

Press ENTER to continue ...
Creating launcher project ...
Now using project "launcher" on server "https://192.168.99.100:8443".

You can add applications to this project with the 'new-app' command. For example, try:

    oc new-app centos/ruby-25-centos7~https://github.com/sclorg/ruby-ex.git

to build a new example application in Ruby.
Processing the template and installing ...
configmap/launcher created
configmap/launcher-clusters created
deploymentconfig.apps.openshift.io/launcher-backend created
service/launcher-backend created
deploymentconfig.apps.openshift.io/launcher-creator-backend created
service/launcher-creator-backend created
deploymentconfig.apps.openshift.io/launcher-frontend created
service/launcher-frontend created
serviceaccount/configmapcontroller created
rolebinding.authorization.openshift.io/configmapcontroller created
deploymentconfig.apps.openshift.io/configmapcontroller created
route.route.openshift.io/launcher created
secret/launcher created
Enabling Launcher Creator
deploymentconfig.apps.openshift.io/launcher-frontend updated
All set! Enjoy!

Note that it does say:

Enabling Launcher Creator
deploymentconfig.apps.openshift.io/launcher-frontend updated

In the ConfigMap I still see launcher.creator.enabled as blank, however. And the UI looks like:

screenshot1

What's going on? :)

ALRubinger commented 5 years ago

UI still looks as pasted even when manually setting launcher.creator.enabled to true and letting the pods redeploy.

gastaldi commented 5 years ago

We need to update the launcher-frontend commit hash in the release.properties file.

Run https://github.com/fabric8-launcher/launcher-openshift-templates/blob/master/scripts/update-released.sh and commit the changes in the launcher-openshift-templates repo

Em Sáb, 16 de mar de 2019 17:23, Andrew Lee Rubinger < notifications@github.com> escreveu:

UI still looks as pasted even when manually setting launcher.creator.enabled to true and letting the pods redeploy.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fabric8-launcher/launcher-openshift-templates/issues/54#issuecomment-473588182, or mute the thread https://github.com/notifications/unsubscribe-auth/AADTdYxIwKWIUgXLeCLJ2QOk0_a525HUks5vXVLDgaJpZM4b4Asw .

quintesse commented 5 years ago

@gastaldi wouldn't that mean that those versions would go to production?

gastaldi commented 5 years ago

@quintesse no, that is only for the minishift installation

ALRubinger commented 5 years ago

Resolved by #55

quintesse commented 5 years ago

no, that is only for the minishift installation

ok!

I added a new option --latest to the install script which will just use the "latest" tag for people who want the latest and greatest without having to wait for those properties to be updated.