search

fabric8-launcher / launcher-openshift-templates

OpenShift Templates for the Fabric8 Launcher application
http://launcher.fabric8.io
Apache License 2.0
5 stars 17 forks source link

Installation fails using --latest #56

Closed ALRubinger closed 5 years ago

ALRubinger commented 5 years ago

Ran:

curl -s https://raw.githubusercontent.com/fabric8-launcher/launcher-openshift-templates/master/scripts/minishift/install.sh | bash -s -- --latest

This script will install the Launcher in Minishift. Make sure that:

- Minishift is running
- You have run oc login previously
- Your GitHub Username is correct [found from git config github.user]: alrubinger
- Your GitHub Token is correct [found from git config github.token]: *REDACTED*

Press ENTER to continue ...
Creating launcher project ...
Now using project "launcher" on server "https://192.168.99.100:8443".

You can add applications to this project with the 'new-app' command. For example, try:

    oc new-app centos/ruby-25-centos7~https://github.com/sclorg/ruby-ex.git

to build a new example application in Ruby.
Processing the template and installing ...
error: failed to read input object (not a Template?): the path "./openshift/launcher-template.yaml" does not exist
error: no objects passed to create
Enabling Launcher Creator
Error from server (NotFound): deploymentconfigs.apps.openshift.io "launcher-frontend" not found
All set! Enjoy!

User error or something in --latest?

ALRubinger commented 5 years ago

Ah; I see - this needs to be run from inside fabric8-launcher/launcher-openshift-templates working copy to use --latest. Is this the intended behaviour?

quintesse commented 5 years ago

Ah... hmmmm... before there were only two options "--remote" (the default) that retrieves it directly from the GH repo. And "--local" that uses the local file for when you run it from within the local working copy.

Making two versions for "--latest" where one is remote and one is local doesn't seem very useful , right?

We could perhaps detect if we're being used with a curl command (how? by seeing that the script is not coming from a file but form a pipe perhaps?) and change the behaviour depending on that... or we just hard-code "--latest" to always use the remote GH repo... opinions?

quintesse commented 5 years ago

Ok, implemented what I suggested first, so your command should now work @ALRubinger