search

fabric8-launcher / launchpad-missioncontrol

Strap in; we're going to production. Now.
Apache License 2.0
10 stars 21 forks source link

Fix OpenShiftUrlTest #94

Closed rimolive closed 7 years ago

rimolive commented 8 years ago

1) If I set env var KONTINUITY_CATAPULT_OPENSHIFT_URL, OpenShiftUrlTest still fails because it tries to connect to https://localhost:8443 (I set to a different IP address).

2) After set KONTINUITY_CATAPULT_OPENSHIFT_URL, it gets the correct OpenShift URL but then the test fails again in this part:

Running org.kontinuity.catapult.service.openshift.impl.OpenShiftUrlTest
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec <<< FAILURE! - in org.kontinuity.catapult.service.openshift.impl.OpenShiftUrlTest
openShiftUrlFromEnvVar(org.kontinuity.catapult.service.openshift.impl.OpenShiftUrlTest)  Time elapsed: 0.008 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<https://[katapult-it-test]:8443> but was:<https://[10.1.2.2]:8443>
    at org.kontinuity.catapult.service.openshift.impl.OpenShiftUrlTest.openShiftUrlFromEnvVar(OpenShiftUrlTest.java:29)
rimolive commented 8 years ago

I changed OpenShiftUrlTest code to make 2) pass but I'm getting the same issue as 1).

ALRubinger commented 7 years ago

Out of date