fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

feat: add api to populate identity cluster relations in cluster service #756

Closed dipak-pawar closed 5 years ago

dipak-pawar commented 5 years ago

Changes Proposed in this PR

codecov[bot] commented 5 years ago

Codecov Report

Merging #756 into master will decrease coverage by 0.02%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   79.03%   79.01%   -0.03%     
==========================================
  Files          94       94              
  Lines        8639     8706      +67     
==========================================
+ Hits         6828     6879      +51     
- Misses       1331     1342      +11     
- Partials      480      485       +5
Impacted Files Coverage Δ
authorization/token/token.go 100% <ø> (ø) :arrow_up:
authentication/account/repository/identity.go 77.02% <58.33%> (-0.45%) :arrow_down:
controller/clusters.go 56.52% <58.33%> (-1.82%) :arrow_down:
cluster/service/cluster.go 86.25% <85%> (-0.08%) :arrow_down:
wit/service/wit_service.go 89.18% <0%> (+0.3%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0471e0...8ec2b02. Read the comment docs.

alexeykazakov commented 5 years ago

Just for clarification. This is a temporal migration endpoint. We will need to use it once and then revert the commits.

dipak-pawar commented 5 years ago

@alexeykazakov: I have tested it locally, everything is working fine. I can see identity linked to cluster after completion of migration