search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Replace buit-in dbcleaner with fabric8-common's one #789

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

also:

fixes #788

codecov[bot] commented 5 years ago

Codecov Report

Merging #789 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
- Coverage   78.77%   78.75%   -0.03%     
==========================================
  Files          95       94       -1     
  Lines        8850     8806      -44     
==========================================
- Hits         6972     6935      -37     
+ Misses       1381     1376       -5     
+ Partials      497      495       -2
Impacted Files Coverage Δ
configuration/configuration.go 84.77% <100%> (+0.11%) :arrow_up:
log/log.go 72.66% <0%> (-1.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90bcc79...05acee1. Read the comment docs.

xcoulon commented 5 years ago

@sbryzak thanks for the review, but actually the first commit only covered half of the work (which I realized only later), so I added another change and also updated the PR title and description to better reflect the nature of the changes. Would you mind giving it another look, please ?

xcoulon commented 5 years ago

thanks for the review @alexeykazakov. I've fixed the formatting and I will merge the PR once the build passed ;)