Closed xcoulon closed 5 years ago
Merging #789 into master will decrease coverage by
0.02%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 78.77% 78.75% -0.03%
==========================================
Files 95 94 -1
Lines 8850 8806 -44
==========================================
- Hits 6972 6935 -37
+ Misses 1381 1376 -5
+ Partials 497 495 -2
Impacted Files | Coverage Δ | |
---|---|---|
configuration/configuration.go | 84.77% <100%> (+0.11%) |
:arrow_up: |
log/log.go | 72.66% <0%> (-1.44%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 90bcc79...05acee1. Read the comment docs.
@sbryzak thanks for the review, but actually the first commit only covered half of the work (which I realized only later), so I added another change and also updated the PR title and description to better reflect the nature of the changes. Would you mind giving it another look, please ?
thanks for the review @alexeykazakov. I've fixed the formatting and I will merge the PR once the build passed ;)
also:
fabric8-common
fabric8-common
fixes #788