search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Deactivate user in WIT and Tenant #790

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

requires #789 to be merged, first.

alexeykazakov commented 5 years ago

Is it still WIP?

xcoulon commented 5 years ago

Is it still WIP?

yes, until #789 is merged, which will happen very soon. I'll ping you again once it's ready for review

codecov[bot] commented 5 years ago

Codecov Report

Merging #790 into master will increase coverage by 0.01%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   78.75%   78.76%   +0.01%     
==========================================
  Files          94       94              
  Lines        8806     8827      +21     
==========================================
+ Hits         6935     6953      +18     
  Misses       1376     1376              
- Partials      495      498       +3
Impacted Files Coverage Δ
wit/service/wit_service.go 91.3% <100%> (+2.41%) :arrow_up:
authentication/account/service/tenant.go 85.18% <100%> (+0.27%) :arrow_up:
controller/user.go 89.09% <100%> (ø) :arrow_up:
controller/namedusers.go 100% <100%> (ø) :arrow_up:
configuration/configuration.go 85.1% <100%> (+0.32%) :arrow_up:
authentication/account/service/user.go 83.73% <50%> (-2.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c02b299...11995c0. Read the comment docs.

xcoulon commented 5 years ago

@alexeykazakov it's ready for your reviewing pleasure, now ;)

xcoulon commented 5 years ago

[test]

xcoulon commented 5 years ago

@alexeykazakov I addressed all your comments. Please let me know if it's ok for you

alexeykazakov commented 5 years ago

Just bring back the tenant call error thingy and everything else looks good! :)

xcoulon commented 5 years ago

Just bring back the tenant call error thingy and everything else looks good! :)

done in 249cd96