search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

delete external tokens during user deactication #794

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

fixes #783

Signed-off-by: Xavier Coulon xcoulon@redhat.com

xcoulon commented 5 years ago

marked as draft as it includes changes for #778. I will rebase this PR once #778 is merged.

codecov[bot] commented 5 years ago

Codecov Report

Merging #794 into master will decrease coverage by 0.06%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   78.73%   78.67%   -0.07%     
==========================================
  Files          94       94              
  Lines        8832     8852      +20     
==========================================
+ Hits         6954     6964      +10     
- Misses       1378     1385       +7     
- Partials      500      503       +3
Impacted Files Coverage Δ
...ation/provider/factory/linking_provider_factory.go 69.23% <100%> (+0.6%) :arrow_up:
authentication/account/service/user.go 79.1% <33.33%> (-2.15%) :arrow_down:
...zation/token/repository/external_provider_token.go 66.66% <53.84%> (-1.82%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d231809...afdcb6a. Read the comment docs.

xcoulon commented 5 years ago

@alexeykazakov I applied changes after you first review, please let me know if you have further concerns