Closed alexeykazakov closed 5 years ago
Thank you @alexeykazakov for this contribution!
It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests
as a comment to make the status green.
Your plugin configuration is stored in the file.
Merging #795 into master will increase coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 78.73% 78.79% +0.05%
==========================================
Files 94 94
Lines 8832 8860 +28
==========================================
+ Hits 6954 6981 +27
+ Misses 1378 1374 -4
- Partials 500 505 +5
Impacted Files | Coverage Δ | |
---|---|---|
authentication/account/service/user.go | 83.97% <0%> (+2.72%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 030bee8...82c8c07. Read the comment docs.
[test]
Currently because of a bug in our template we do not set client ID env var correctly, so we always use the default value which is "fabric8-platform-online". But we have to fix this altogether with updating the corresponding secret when switching to RHD SSO.
Should be merged only when we update CM/Secrets to switch to RHD! If we merge it without updating the secrets then incorrect ID will be used.