fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

expose endpoint to deactivate user #799

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

using mocks to verify that controller calls the UserService

also, make sure that all mocks are generated in test/generated pkg

fixes #780

xcoulon commented 5 years ago

@alexeykazakov I fixed the problems you reported. Please let me know if you have further concerns ;)

codecov[bot] commented 5 years ago

Codecov Report

Merging #799 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   78.52%   78.52%   -0.01%     
==========================================
  Files          94       94              
  Lines        8882     8841      -41     
==========================================
- Hits         6975     6942      -33     
+ Misses       1392     1386       -6     
+ Partials      515      513       -2
Impacted Files Coverage Δ
controller/namedusers.go 100% <100%> (ø) :arrow_up:
...rovider/service/authentication_provider_service.go 68% <0%> (-4.9%) :arrow_down:
wit/service/wit_service.go 95.83% <0%> (+4.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9b7b20...b86ff3f. Read the comment docs.