fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Rename `deprovision` to `ban` endpoint #802

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

Create a new ban endpoint and internally forward all incoming requests from deprovision to ban Also, rename all references of deprovision to ban, including a new column ban in the database, containing the same values as its sibling column deprovision. Both columns should be updated in parallel until the transition to the new endpoint is complete.

Fixes #ODC117

codecov[bot] commented 5 years ago

Codecov Report

Merging #802 into master will increase coverage by 0.02%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   78.52%   78.55%   +0.02%     
==========================================
  Files          94       94              
  Lines        8842     8849       +7     
==========================================
+ Hits         6943     6951       +8     
  Misses       1386     1386              
+ Partials      513      512       -1
Impacted Files Coverage Δ
authentication/account/repository/user.go 84.88% <ø> (ø) :arrow_up:
authorization/team/service/team_service.go 70.27% <0%> (ø) :arrow_up:
...orization/invitation/service/invitation_service.go 70.79% <0%> (ø) :arrow_up:
authentication/account/service/user.go 79.25% <100%> (+0.15%) :arrow_up:
controller/userinfo.go 100% <100%> (ø) :arrow_up:
controller/resource_roles.go 85.43% <100%> (ø) :arrow_up:
controller/namedusers.go 100% <100%> (ø) :arrow_up:
controller/token.go 84.54% <100%> (ø) :arrow_up:
controller/user.go 89.09% <100%> (ø) :arrow_up:
controller/search.go 92.53% <100%> (ø) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a11b741...2d3f897. Read the comment docs.

alexeykazakov commented 5 years ago

‘’’ ERROR: These files differ from gofmt's style (run 'make format-go-code' to fix this): ./test/account.go ‘’’

xcoulon commented 5 years ago

‘’’ ERROR: These files differ from gofmt's style (run 'make format-go-code' to fix this): ./test/account.go ‘’’

ahem, let me fix that 😬

xcoulon commented 5 years ago

‘’’ ERROR: These files differ from gofmt's style (run 'make format-go-code' to fix this): ./test/account.go ‘’’

ahem, let me fix that 😬

fixed in 2d3f897