search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Set default value on all empty `last_activity` records #803

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

Only update null values Also make sure that new values do not have an empty value from now on.

Fixes #ODC184

xcoulon commented 5 years ago

Note: we can't make the column last_active as non nullable for now, or at least until the application has been deployed on all pods at least once, without a need to rollback.

codecov[bot] commented 5 years ago

Codecov Report

Merging #803 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   78.52%   78.52%   +<.01%     
==========================================
  Files          94       94              
  Lines        8841     8842       +1     
==========================================
+ Hits         6942     6943       +1     
  Misses       1386     1386              
  Partials      513      513
Impacted Files Coverage Δ
migration/migration.go 66.07% <100%> (+0.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90c741f...0b1f2f5. Read the comment docs.