search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

merge subscription and subscription/service pkg #810

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

also, remove the dummy subscription service impl and use Gock to mock calls to the Registration App in tests, instead.

Fixes #ODC386

Signed-off-by: Xavier Coulon xcoulon@redhat.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #810 into master will increase coverage by 0.28%. The diff coverage is 84.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   78.49%   78.77%   +0.28%     
==========================================
  Files          94       92       -2     
  Lines        8951     9046      +95     
==========================================
+ Hits         7026     7126     +100     
+ Misses       1405     1397       -8     
- Partials      520      523       +3
Impacted Files Coverage Δ
...n/subscription/service/oso_subscription_service.go 87.34% <84.9%> (-5.52%) :arrow_down:
...rovider/service/authentication_provider_service.go 61.11% <0%> (-5.02%) :arrow_down:
authentication/account/repository/identity.go 80.48% <0%> (+3.31%) :arrow_up:
migration/migration.go 70.81% <0%> (+4.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 887c07f...49163ea. Read the comment docs.

xcoulon commented 5 years ago

thanks for your reviews, @sbryzak and @alexeykazakov 🙌