Closed xcoulon closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@22f8242
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #811 +/- ##
=========================================
Coverage ? 78.78%
=========================================
Files ? 94
Lines ? 9069
Branches ? 0
=========================================
Hits ? 7145
Misses ? 1400
Partials ? 524
Impacted Files | Coverage Δ | |
---|---|---|
authentication/account/repository/identity.go | 80.86% <100%> (ø) |
|
authentication/account/service/user.go | 76.8% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 22f8242...a8be694. Read the comment docs.
@sbryzak to answer your question above (not sure why I can't reply directly after your comment, but 🤷♂️): yes, the deactivation_notification
column is set back to NULL
when the user is active again: https://github.com/fabric8-services/fabric8-auth/blob/master/authentication/account/repository/identity.go#L888
this will avoid the case where the user receives a notification but gets deactivated the next day (if the notification was sent too late)
Fixes #ODC394
Signed-off-by: Xavier Coulon xcoulon@redhat.com