Closed xcoulon closed 5 years ago
@xcoulon looks good, I have added few comments just for taking your input on the same :+1:
Merging #815 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 78.51% 78.51% +<.01%
==========================================
Files 92 92
Lines 8964 8966 +2
==========================================
+ Hits 7038 7040 +2
Misses 1413 1413
Partials 513 513
Impacted Files | Coverage Δ | |
---|---|---|
authentication/account/repository/identity.go | 77.16% <100%> (ø) |
:arrow_up: |
authentication/account/service/user.go | 77.04% <100%> (+0.23%) |
:arrow_up: |
notification/notification.go | 95.34% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b4c732c...fd9d44a. Read the comment docs.
@nurali-techie I addressed your comments. Could you review the PR again, please?
thanks @nurali-techie 🙌
Fixes #ODC507
Signed-off-by: Xavier Coulon xcoulon@redhat.com