search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

add env for Che in deployment template #817

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

include required env var for the Che service URL in the deployment template.

Signed-off-by: Xavier Coulon xcoulon@redhat.com

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @xcoulon for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #817 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage    78.5%   78.51%   +<.01%     
==========================================
  Files          98       98              
  Lines        9157     9158       +1     
==========================================
+ Hits         7189     7190       +1     
  Misses       1438     1438              
  Partials      530      530
Impacted Files Coverage Δ
configuration/configuration.go 83.44% <100%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cabb861...546f4e1. Read the comment docs.

alexeykazakov commented 5 years ago

/ok-without-tests

alexeykazakov commented 5 years ago

[test]